mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.
Date Wed, 01 Aug 2018 20:02:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67932/#review206757
-----------------------------------------------------------



Bad patch!

Reviews applied: [67932, 67984, 67930, 67931]

Failed command: python support/apply-reviews.py -n -r 67931

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-01 20:02:36 URL:https://reviews.apache.org/r/67931/diff/raw/ [39119/39119] -> "67931.patch"
[1]
error: patch failed: src/uri/fetchers/docker.hpp:58
error: src/uri/fetchers/docker.hpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22982/console

- Mesos Reviewbot


On July 31, 2018, 9:41 p.m., Liangyu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67932/
> -----------------------------------------------------------
> 
> (Updated July 31, 2018, 9:41 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `tar` command cannot work successfully on Windows, so use `wclayer`
> instead. Note that the folder generated from extraction also cannot be
> deleted by `rmdir`, so the GC is also changed to use `wclayer remove`.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc 
>   src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 85aad25ac8ecfda125be85fb46d882c3982f3930

> 
> 
> Diff: https://reviews.apache.org/r/67932/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message