mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] asfgit closed pull request #205: Clarify existence of FrameworkID in SUBSCRIBE calls.
Date Thu, 30 Aug 2018 20:43:22 GMT
asfgit closed pull request #205: Clarify existence of FrameworkID in SUBSCRIBE calls.
URL: https://github.com/apache/mesos/pull/205
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/scheduler-http-api.md b/docs/scheduler-http-api.md
index 7f808f10a9..58921155d8 100644
--- a/docs/scheduler-http-api.md
+++ b/docs/scheduler-http-api.md
@@ -91,7 +91,7 @@ Network intermediaries (e.g., proxies) are free to change the chunk boundaries;
 
 This is the first step in the communication process between the scheduler and the master.
This is also to be considered as subscription to the "/scheduler" event stream.
 
-To subscribe with the master, the scheduler sends an HTTP POST with a `SUBSCRIBE` message
including the required FrameworkInfo. Note that if "subscribe.framework_info.id" is not set,
master considers the scheduler as a new one and subscribes it by assigning it a FrameworkID.
The HTTP response is a stream in RecordIO format; the event stream begins with a `SUBSCRIBED`
event (see details in **Events** section). The response also includes the `Mesos-Stream-Id`
header, which is used by the master to uniquely identify the subscribed scheduler instance.
This stream ID header should be included in all subsequent non-`SUBSCRIBE` calls sent over
this subscription connection to the master. The value of `Mesos-Stream-Id` is guaranteed to
be at most 128 bytes in length.
+To subscribe with the master, the scheduler sends an HTTP POST with a `SUBSCRIBE` message
including the required FrameworkInfo. Note that if "subscribe.framework_info.id" and "FrameworkID"
are not set, the master considers the scheduler as a new one and subscribes it by assigning
it a FrameworkID. The HTTP response is a stream in RecordIO format; the event stream begins
with a `SUBSCRIBED` event (see details in **Events** section). The response also includes
the `Mesos-Stream-Id` header, which is used by the master to uniquely identify the subscribed
scheduler instance. This stream ID header should be included in all subsequent non-`SUBSCRIBE`
calls sent over this subscription connection to the master. The value of `Mesos-Stream-Id`
is guaranteed to be at most 128 bytes in length.
 
 ```
 SUBSCRIBE Request (JSON):
@@ -131,7 +131,7 @@ Mesos-Stream-Id: 130ae4e3-6b13-4ef4-baa9-9f2e85c3e9af
 <more events>
 ```
 
-Alternatively, if "subscribe.framework_info.id" is set, master considers this a request from
an already subscribed scheduler reconnecting after a disconnection (e.g., due to master/scheduler
failover or network disconnection) and responds
+Alternatively, if "subscribe.framework_info.id" and "FrameworkID" are set, the master considers
this a request from an already subscribed scheduler reconnecting after a disconnection (e.g.,
due to master/scheduler failover or network disconnection) and responds
 with a `SUBSCRIBED` event. For further details, see the **Disconnections** section below.
 
 NOTE: In the old version of the API, (re-)registered callbacks also included MasterInfo,
which contained information about the master the driver currently connected to. With the new
API, since schedulers explicitly subscribe with the leading master (see details below in **Master
Detection** section), it's not relevant anymore.


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message