mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jdef commented on a change in pull request #294: FaultDomain, conventions for additional hierarchy.
Date Mon, 27 Aug 2018 21:36:21 GMT
jdef commented on a change in pull request #294: FaultDomain, conventions for additional hierarchy.
URL: https://github.com/apache/mesos/pull/294#discussion_r213123800
 
 

 ##########
 File path: include/mesos/mesos.proto
 ##########
 @@ -827,6 +827,18 @@ message ExecutorInfo {
  * in the same zone, in different zones in the same region, or in
  * different regions. Note that all masters in a given Mesos cluster
  * must be in the same region.
+ *
+ * Complex deployments may have additional levels of hierarchy: for example,
+ * multiple racks might be grouped together into "halls" and multiple DCs in
+ * the same geographical vicinity might be grouped together. As a convention,
+ * the recommended way to represent additional levels of hierarchy is via dot-
 
 Review comment:
   I realize that Mesos doesn't care. The goal of having a convention was to promote compatibility
across frameworks and clusters that can handle additional levels of hierarchy. Consistency
suffers w/o convention. This was the justification for adding the same commentary to the design
doc, and it's just as relevant (and much easier to find) here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message