From reviews-return-80477-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 31 23:25:32 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BF7A18CC8 for ; Tue, 31 Jul 2018 23:25:32 +0000 (UTC) Received: (qmail 38199 invoked by uid 500); 31 Jul 2018 23:25:32 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 38169 invoked by uid 500); 31 Jul 2018 23:25:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 38158 invoked by uid 99); 31 Jul 2018 23:25:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jul 2018 23:25:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4051B1808B7; Tue, 31 Jul 2018 23:25:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id UCbChO6bI9ZN; Tue, 31 Jul 2018 23:25:30 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 42D985F2FF; Tue, 31 Jul 2018 23:25:30 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D60ACE01C2; Tue, 31 Jul 2018 23:25:29 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A4710C40151; Tue, 31 Jul 2018 23:25:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1253983136032572492==" MIME-Version: 1.0 Subject: Re: Review Request 67187: Tested per-framework task state metrics. From: Greg Mann To: =?utf-8?q?Gast=C3=B3n_Kleiman?= Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Greg Mann , mesos Date: Tue, 31 Jul 2018 23:25:29 -0000 Message-ID: <20180731232529.42424.57109@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67187/ X-Sender: Greg Mann References: <20180731015351.44302.90436@reviews-vm2.apache.org> In-Reply-To: <20180731015351.44302.90436@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============1253983136032572492== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ ----------------------------------------------------------- (Updated July 31, 2018, 11:25 p.m.) Review request for mesos, Gastón Kleiman and Gilbert Song. Bugs: MESOS-8847 https://issues.apache.org/jira/browse/MESOS-8847 Repository: mesos Description ------- This patch adds `MasterTest.TaskStateMetrics`, which verifies that per-framework task state metrics for both terminal and active task states report correct values, even after agent reregistration. Diffs (updated) ----- src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 Diff: https://reviews.apache.org/r/67187/diff/9/ Changes: https://reviews.apache.org/r/67187/diff/8-9/ Testing ------- The new test was run ~10,000 times with no failures. Thanks, Greg Mann --===============1253983136032572492==--