From reviews-return-80471-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 31 22:33:41 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B6161898E for ; Tue, 31 Jul 2018 22:33:41 +0000 (UTC) Received: (qmail 41696 invoked by uid 500); 31 Jul 2018 22:33:41 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 41662 invoked by uid 500); 31 Jul 2018 22:33:41 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 41649 invoked by uid 99); 31 Jul 2018 22:33:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jul 2018 22:33:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 87135C00E1; Tue, 31 Jul 2018 22:33:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ITQpDUW4Wfgx; Tue, 31 Jul 2018 22:33:39 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C1CB65F27B; Tue, 31 Jul 2018 22:33:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 163D1E01C2; Tue, 31 Jul 2018 22:33:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 03690C40151; Tue, 31 Jul 2018 22:33:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8544198174564495243==" MIME-Version: 1.0 Subject: Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`. From: Andrew Schwartzmeyer To: Akash Gupta , Joseph Wu , Andrew Schwartzmeyer Cc: Liangyu Zhao , mesos Date: Tue, 31 Jul 2018 22:33:38 -0000 Message-ID: <20180731223338.42424.3866@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67984/ X-Sender: Andrew Schwartzmeyer X-ReviewBoard-ShipIt: 1 References: <20180731214244.42424.52936@reviews-vm2.apache.org> In-Reply-To: <20180731214244.42424.52936@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============8544198174564495243== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/#review206694 ----------------------------------------------------------- Ship it! I'll make sure this gets committed with original authorship (me); I thought RB would preserve it, but apparently not, I guess it takes it from the user submitting. Oh well. - Andrew Schwartzmeyer On July 31, 2018, 2:42 p.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67984/ > ----------------------------------------------------------- > > (Updated July 31, 2018, 2:42 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Added CMake logic to download and "install" `wclayer.exe`. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f > src/slave/CMakeLists.txt e5fe32a265e310f568139127ee6e5f441590985c > > > Diff: https://reviews.apache.org/r/67984/diff/2/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > > --===============8544198174564495243==--