From reviews-return-80154-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 23 09:31:45 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7FD9E18E8F for ; Mon, 23 Jul 2018 09:31:45 +0000 (UTC) Received: (qmail 87202 invoked by uid 500); 23 Jul 2018 09:31:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 87166 invoked by uid 500); 23 Jul 2018 09:31:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87147 invoked by uid 99); 23 Jul 2018 09:31:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jul 2018 09:31:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 58BBCC03BD; Mon, 23 Jul 2018 09:31:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.2 X-Spam-Level: * X-Spam-Status: No, score=1.2 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id FGu5ZdPmGr-5; Mon, 23 Jul 2018 09:31:40 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A6A3C5F27E; Mon, 23 Jul 2018 09:31:39 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0EEFAE0178; Mon, 23 Jul 2018 09:31:39 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D153DC40067; Mon, 23 Jul 2018 09:31:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7458284111306772316==" MIME-Version: 1.0 Subject: Re: Review Request 67987: Added rapidjson to the mesos build. From: Benno Evers To: James Peach , Alexander Rukletsov , Benno Evers Cc: Benjamin Mahler , mesos Date: Mon, 23 Jul 2018 09:31:38 -0000 Message-ID: <20180723093138.17746.70930@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67987/ X-Sender: Benno Evers X-ReviewBoard-ShipIt: 1 References: <20180720033853.38147.69975@reviews-vm2.apache.org> In-Reply-To: <20180720033853.38147.69975@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/rapidjson-1.1.0.tar.gz X-ReviewBoard-Diff-For: 3rdparty/rapidjson.md Reply-To: Benno Evers X-ReviewRequest-Repository: mesos --===============7458284111306772316== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67987/#review206334 ----------------------------------------------------------- Fix it, then Ship it! 3rdparty/Makefile.am Lines 367 (patched) This can be shortened a bit, since we already have the list stored in a variable: ``` $(nodist_rapidjson_HEADERS): $(RAPIDJSON)-stamp ``` - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67987/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 3:38 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benno Evers, and James Peach. > > > Bugs: MESOS-9092 > https://issues.apache.org/jira/browse/MESOS-9092 > > > Repository: mesos > > > Description > ------- > > This includes a stripped bundle of the latest release. Stripping > is required for licensing (see rapidjson.md), but also helps reduce > the bloat in the mesos git repo. > > Also included is a readme for how to update the dependency. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f > 3rdparty/Makefile.am 6123b8a0164d50f0bd771d2e5f485379811e7fcb > 3rdparty/README.md fa9a6483ca2dc4980767a2cb723d654e342e6bb8 > 3rdparty/cmake/Versions.cmake 0a897d808cd9e05ac0d1a4e1ca61b8f3538f0c4a > 3rdparty/rapidjson-1.1.0.tar.gz PRE-CREATION > 3rdparty/rapidjson.md PRE-CREATION > 3rdparty/versions.am 57792800c4b4b67dd55a316ce00480db6c253d34 > configure.ac e86c496140ee9732ad3204ef22ae8ce60cd5c079 > src/Makefile.am ecb95ef152fd37e5e83c4f6415489f4cf3959578 > > > Diff: https://reviews.apache.org/r/67987/diff/2/ > > > Testing > ------- > > Tested at the end of this chain, since this is split across stout/libprocess/mesos. > > > Thanks, > > Benjamin Mahler > > --===============7458284111306772316==--