From reviews-return-79965-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 17 18:16:59 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E015184AF for ; Tue, 17 Jul 2018 18:16:59 +0000 (UTC) Received: (qmail 55784 invoked by uid 500); 17 Jul 2018 18:16:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 55752 invoked by uid 500); 17 Jul 2018 18:16:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 55740 invoked by uid 99); 17 Jul 2018 18:16:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jul 2018 18:16:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 57A6CC0910; Tue, 17 Jul 2018 18:16:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.2 X-Spam-Level: * X-Spam-Status: No, score=1.2 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WTm3-r8u4Q7g; Tue, 17 Jul 2018 18:16:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3374E5F19D; Tue, 17 Jul 2018 18:16:55 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B550AE00D3; Tue, 17 Jul 2018 18:16:54 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6C357C402BB; Tue, 17 Jul 2018 18:16:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7765210404094354809==" MIME-Version: 1.0 Subject: Re: Review Request 67931: Support Image Manifest Version 2 Schema 2. From: Andrew Schwartzmeyer To: Akash Gupta , Joseph Wu , Andrew Schwartzmeyer Cc: Liangyu Zhao , mesos Date: Tue, 17 Jul 2018 18:16:54 -0000 Message-ID: <20180717181654.2994.57025@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67931/ X-Sender: Andrew Schwartzmeyer References: <20180716183550.13476.38491@reviews-vm2.apache.org> In-Reply-To: <20180716183550.13476.38491@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: include/mesos/docker/v2_2.proto X-ReviewBoard-Diff-For: include/mesos/docker/v2_2.hpp Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============7765210404094354809== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206157 ----------------------------------------------------------- There is still more to review... I'll get to it. include/mesos/docker/spec.hpp Lines 124-126 (patched) I think this and the commit before need to be re-ordered, as this commit is introducing logic required and used by the previous commit. include/mesos/docker/spec.hpp Lines 141 (patched) Dumb question, but is there an S1/S2 for V1 as well? include/mesos/docker/spec.hpp Lines 141-164 (patched) I'm not sure, but would this be better as a variant? ``` std::unique_ptr> manifest; ``` (Declared at point of use.) P.S. Why do we need pointers? include/mesos/uri/fetcher.hpp Lines 84-96 (patched) Maybe add to this comment (and the one below) that this is used by the V2_S2 schema. src/docker/spec.cpp Lines 390-426 (patched) I think you'd get all of this for "free" out of a variant. src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp Lines 467 (patched) Why do we need a `shared_ptr` here? src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp Lines 473 (patched) Heyyy what is this... src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp Lines 490 (patched) Why are we making this on the heap and using a pointer? src/uri/fetcher.cpp Line 56 (original), 56 (patched) We can delete this now! Also, add `MESOS-8570` to the "bug" field of this review, and let's get you a JIRA account so I can assign it to you. src/uri/fetcher.cpp Lines 88 (patched) Why does this function throw away `urls`? - Andrew Schwartzmeyer On July 16, 2018, 11:35 a.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67931/ > ----------------------------------------------------------- > > (Updated July 16, 2018, 11:35 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Support parsing schema 2 and fetching blob with multiple URLs as > specified in schema 2. Update `curl` version to 7.60.0 because of bug > encountered in version 7.57.0. > > > Diffs > ----- > > 3rdparty/cmake/Versions.cmake 0a897d808cd9e05ac0d1a4e1ca61b8f3538f0c4a > include/mesos/docker/spec.hpp 2879414dc42ffe633ac74b51e1bb116698c41162 > include/mesos/docker/v2_2.hpp PRE-CREATION > include/mesos/docker/v2_2.proto PRE-CREATION > include/mesos/uri/fetcher.hpp 760d6b33234d8efdc533c0c6f05e83a5c7d1f56b > src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 > src/Makefile.am 228e168c22f3fd0367f029c506171c6979b31c07 > src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9 > src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 > src/uri/fetcher.hpp fbf64c6767dea3aa0798f68db8322ce47cd8ad36 > src/uri/fetcher.cpp 489c7ce0198ee6803dcc8eb9710b292fa743a0e8 > src/uri/fetchers/docker.hpp cdbab9a5684a68a729be12bc06d331acca137da5 > src/uri/fetchers/docker.cpp 55ca118660872a933a2dc186723bec6a39ee80f7 > > > Diff: https://reviews.apache.org/r/67931/diff/1/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > > --===============7765210404094354809==--