----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67930/#review206156 ----------------------------------------------------------- src/tests/environment.cpp Line 526 (original), 526-530 (patched) It's just funny how many times we've "enabled" this and still not actually committed it. We'll have to make sure CI passes this chain. src/tests/uri_fetcher_tests.cpp Line 284 (original), 284-288 (patched) Since we're checking against this multiple times below, let's define it once as a constant with a per-platform value, and then just reuse the constant (so the rest of the ifdef's go away). src/tests/uri_fetcher_tests.cpp Lines 305-312 (patched) What's the reason this has to _only_ be done on Windows? src/tests/uri_fetcher_tests.cpp Lines 307 (patched) s/Verision/Version - Andrew Schwartzmeyer On July 16, 2018, 11:35 a.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67930/ > ----------------------------------------------------------- > > (Updated July 16, 2018, 11:35 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Enabled Internet test environment on Windows. Disabled Internet > HealthCheckTests on Windows, since they require complete development. > Modified DockerFetcherPluginTest to fetch `microsoft/nanoserver` for > more extensive test for fetcher on Windows. > > > Diffs > ----- > > src/tests/environment.cpp 3b84c0a413193badbbdb6d3ee71d74f3ab85c90b > src/tests/health_check_tests.cpp 34102e2e3ff90c194bea83ae8a702181121d6522 > src/tests/uri_fetcher_tests.cpp 816d8ec2503ea79d069c062dfa2f01224b263bf6 > > > Diff: https://reviews.apache.org/r/67930/diff/1/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > >