From reviews-return-79683-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 10 02:17:49 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1068E184A7 for ; Tue, 10 Jul 2018 02:17:49 +0000 (UTC) Received: (qmail 41056 invoked by uid 500); 10 Jul 2018 02:17:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 41016 invoked by uid 500); 10 Jul 2018 02:17:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 41005 invoked by uid 99); 10 Jul 2018 02:17:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jul 2018 02:17:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D792F1A0348; Tue, 10 Jul 2018 02:17:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ANqwR2PqILZy; Tue, 10 Jul 2018 02:17:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4C4695F20B; Tue, 10 Jul 2018 02:17:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E5C13E0056; Tue, 10 Jul 2018 02:17:45 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B02D8C4022A; Tue, 10 Jul 2018 02:17:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0792950578135325366==" MIME-Version: 1.0 Subject: Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures. From: Mesos Reviewbot Windows To: Greg Mann , Jiang Yan Xu , Alexander Rojas Cc: Mesos Reviewbot Windows , mesos , =?utf-8?q?Gast=C3=B3n_Kleiman?= Date: Tue, 10 Jul 2018 02:17:45 -0000 Message-ID: <20180710021745.6977.54343@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67791/ X-Sender: Mesos Reviewbot Windows References: <20180710002016.6977.19069@reviews-vm2.apache.org> In-Reply-To: <20180710002016.6977.19069@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============0792950578135325366== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205884 ----------------------------------------------------------- PASS: Mesos patch 67791 was successfully built and tested. Reviews applied: `['67791']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1889/mesos-review-67791 - Mesos Reviewbot Windows On July 10, 2018, 12:20 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67791/ > ----------------------------------------------------------- > > (Updated July 10, 2018, 12:20 a.m.) > > > Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu. > > > Bugs: MESOS-8987 > https://issues.apache.org/jira/browse/MESOS-8987 > > > Repository: mesos > > > Description > ------- > > The Mesos master sends a `ShutdownMessage` to an agent if there is an > authentication or an authorization error during agent (re)registration. > > Upon receipt of this message, the agent kills alls its tasks and commits > suicide. This means that transient auth errors can lead to whole agents > being killed along with it's tasks. > > This patch prevents the master from sending a `ShutdownMessage` in these > cases. > > > Diffs > ----- > > src/master/master.cpp 0c0d6ca375b806a02625261f7e272a126bc4debe > src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 > src/tests/master_authorization_tests.cpp 80b9d49ba334b915461ff5d6df6c9f922d7593e3 > > > Diff: https://reviews.apache.org/r/67791/diff/6/ > > > Testing > ------- > > `bin/mesos-tests.sh` on GNU/Linux > > > Thanks, > > Gastón Kleiman > > --===============0792950578135325366==--