From reviews-return-79512-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 3 23:57:48 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBD6A1822F for ; Tue, 3 Jul 2018 23:57:47 +0000 (UTC) Received: (qmail 23873 invoked by uid 500); 3 Jul 2018 23:57:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23838 invoked by uid 500); 3 Jul 2018 23:57:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23827 invoked by uid 99); 3 Jul 2018 23:57:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jul 2018 23:57:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C2433C006A; Tue, 3 Jul 2018 23:57:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.797 X-Spam-Level: ** X-Spam-Status: No, score=2.797 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, MANY_SPAN_IN_TEXT=2.097, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Y6HtemIYwNdK; Tue, 3 Jul 2018 23:57:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6A09D5F2C5; Tue, 3 Jul 2018 23:57:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0421BE02BE; Tue, 3 Jul 2018 23:57:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E1E8FC400B9; Tue, 3 Jul 2018 23:57:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6591393622423833530==" MIME-Version: 1.0 Subject: Re: Review Request 67822: Avoid duplicate unmount dangling mount point. From: Mesos Reviewbot Windows To: Chun-Hung Hsiao , Jie Yu , Jason Lai Cc: Zhitao Li , Mesos Reviewbot Windows , mesos Date: Tue, 03 Jul 2018 23:57:43 -0000 Message-ID: <20180703235743.16677.6495@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67822/ X-Sender: Mesos Reviewbot Windows References: <20180703230506.16677.2096@reviews-vm2.apache.org> In-Reply-To: <20180703230506.16677.2096@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============6591393622423833530== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67822/#review205701 ----------------------------------------------------------- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['67822']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67822 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67822/logs/mesos-tests-stdout.log): ``` [ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling [ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (799 ms) [ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer [ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (602 ms) [ RUN ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed [ OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1223 ms) [ RUN ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure [ OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (797 ms) [ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure [ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (798 ms) [ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard [ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (998 ms) [ RUN ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer [ OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (598 ms) [ RUN ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning [ OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5663 ms) [ RUN ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS [ OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5054 ms) [----------] 24 tests from DockerContainerizerTest (94432 ms total) [----------] 1 test from HungDockerTest [ RUN ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @0000009F9197BAD0. d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @0000009F9197BD30. d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000001DC0E849B70. d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000001DC102C83F0. d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000001DC1032FF98. ERROR: 5 leaked mock objects found at program exit. ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67822/logs/mesos-tests-stderr.log): ``` I0703 23:57:27.244422 9236 authenticatee.cpp:299] Authentication success I0703 23:57:27.244422 8176 master.cpp:9802] Successfully authenticated principal 'test-principal' at scheduler-4041de1d-6166-4bbb-b556-c212ca226ffb@192.10.1.5:54281 I0703 23:57:27.245590 3596 sched.cpp:501] Successfully authenticated with master master@192.10.1.5:54281 I0703 23:57:27.246424 8904 master.cpp:2927] Received SUBSCRIBE call for framework 'default' at scheduler-4041de1d-6166-4bbb-b556-c212ca226ffb@192.10.1.5:54281 I0703 23:57:27.246424 8904 master.cpp:2234] Authorizing framework principal 'test-principal' to receive offers for roles '{ * }' I0703 23:57:27.247543 5592 master.cpp:3008] Subscribing framework default with checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ] I0703 23:57:27.247543 5592 master.cpp:9993] Adding framework 47858352-1ace-49d6-acc8-1f058e7e7d50-0000 (default) at scheduler-4041de1d-6166-4bbb-b556-c212ca226ffb@192.10.1.5:54281 with roles { } suppressed I0703 23:57:27.249433 6716 sched.cpp:749] Framework registered with 47858352-1ace-49d6-acc8-1f058e7e7d50-0000 I0703 23:57:27.249433 9236 hierarchical.cpp:299] Added framework 47858352-1ace-49d6-acc8-1f058e7e7d50-0000 E0703 23:57:27.339431 9236 slave.cpp:7289] EXIT with status 1: Failed to perform recovery: Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat -H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not recognized as an internal or external command, operable program or batch file. ' If recovery failed due to a change in configuration and you want to keep the current agent id, you might want to change the `--reconfiguration_policy` flag to a more permissive value. To restart this agent with a new agent id instead, do as follows: rm -f C:\Users\jenkins\AppData\Local\Temp\VrabYs\meta\slaves\latest This ensures that the agent does not recover old live executors. If you use the Docker containerizer and think that the Docker daemon state is broken, you can try to clear it. But be careful: these commands will erase all containers and images from this host, not just those started by Mesos! docker kill $(docker ps -q) docker rm $(docker ps -a -q) docker rmi $(docker images -q) Finally, restart the agent. ``` - Mesos Reviewbot Windows On July 3, 2018, 11:05 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67822/ > ----------------------------------------------------------- > > (Updated July 3, 2018, 11:05 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu. > > > Bugs: MESOS-9049 > https://issues.apache.org/jira/browse/MESOS-9049 > > > Repository: mesos > > > Description > ------- > > We could potentially schedule the framework dir, executor dir, and > executor run sandbox to gc at the same time, and then these > paths will be gc independently, although they are parents and > children directories. This patch makes sure we do not call unmount > anymore after a success. > > > Diffs > ----- > > src/slave/gc.cpp 407f6b23f87cf2e2bdaf873c8adcda57f5d559b3 > > > Diff: https://reviews.apache.org/r/67822/diff/2/ > > > Testing > ------- > > ```make``` > > > Thanks, > > Zhitao Li > > --===============6591393622423833530==--