From reviews-return-79467-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 3 14:32:27 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A153F189F4 for ; Tue, 3 Jul 2018 14:32:27 +0000 (UTC) Received: (qmail 40342 invoked by uid 500); 3 Jul 2018 14:32:27 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 40311 invoked by uid 500); 3 Jul 2018 14:32:27 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 40300 invoked by uid 99); 3 Jul 2018 14:32:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jul 2018 14:32:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8B6A7CA6CB; Tue, 3 Jul 2018 14:32:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.949 X-Spam-Level: X-Spam-Status: No, score=0.949 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id PdyUY9zhJkCu; Tue, 3 Jul 2018 14:32:22 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E91705F543; Tue, 3 Jul 2018 14:32:21 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 52571E0361; Tue, 3 Jul 2018 14:32:21 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3A380C4013E; Tue, 3 Jul 2018 14:32:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5826182564339867272==" MIME-Version: 1.0 Subject: Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`. From: Armand Grillet To: Benjamin Bannier , Kevin Klues , Andrew Schwartzmeyer , Eric Chung Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Armand Grillet , mesos Date: Tue, 03 Jul 2018 14:32:21 -0000 Message-ID: <20180703143221.16677.29030@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Armand Grillet X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67413/ X-Sender: Armand Grillet References: <20180612134657.44565.50948@reviews-vm2.apache.org> In-Reply-To: <20180612134657.44565.50948@reviews-vm2.apache.org> Reply-To: Armand Grillet X-ReviewRequest-Repository: mesos --===============5826182564339867272== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67413/ ----------------------------------------------------------- (Updated July 3, 2018, 2:32 p.m.) Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin Klues. Changes ------- Updated review request to not use `PYTHON_3` and `PYTHON_3_VERSION` yet. Summary (updated) ----------------- Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`. Bugs: MESOS-8955 https://issues.apache.org/jira/browse/MESOS-8955 Repository: mesos Description (updated) ------- This will facilitate the introduction of `PYTHON_3` and `PYTHON_3_VERSION` to build the CLI in a future commit. Diffs (updated) ----- configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65 Diff: https://reviews.apache.org/r/67413/diff/8/ Changes: https://reviews.apache.org/r/67413/diff/7-8/ Testing ------- I added two lines after the new code: ``` AC_MSG_NOTICE([$PYTHON]) AC_MSG_NOTICE([$PYTHON_3]) ``` My machine runs Python 2 when using `python` but `python3` is available. The result of `configure` was: ``` configure: /usr/bin/python configure: python3 ``` Thanks, Armand Grillet --===============5826182564339867272==--