mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 67187: Tested per-framework task state metrics.
Date Tue, 31 Jul 2018 22:46:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67187/#review206701
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_tests.cpp
Lines 9117 (patched)
<https://reviews.apache.org/r/67187/#comment289773>

    Nit: do we nee the `mesos::internal::` prefix? No other test seems to need it.



src/tests/master_tests.cpp
Lines 9123 (patched)
<https://reviews.apache.org/r/67187/#comment289774>

    Ditto prefix.


- Gastón Kleiman


On July 30, 2018, 6:53 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67187/
> -----------------------------------------------------------
> 
> (Updated July 30, 2018, 6:53 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Gilbert Song.
> 
> 
> Bugs: MESOS-8847
>     https://issues.apache.org/jira/browse/MESOS-8847
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds `MasterTest.TaskStateMetrics`, which verifies that
> per-framework task state metrics for both terminal and active task
> states report correct values, even after agent reregistration.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 
> 
> 
> Diff: https://reviews.apache.org/r/67187/diff/8/
> 
> 
> Testing
> -------
> 
> The new test was run ~10,000 times with no failures.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message