mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <>
Subject Re: Review Request 68120: UI: Pull up the leader URL generation to a top-level function.
Date Tue, 31 Jul 2018 19:26:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 31, 2018, 7:26 p.m.)

Review request for mesos, Armand Grillet and Gastón Kleiman.


Updated the html to indicate that the log viewer is pointing to the leading master's log.

Repository: mesos

Description (updated)

This path pulls up the leader URL prefix generation to a top-level
function in order to have it re-used across controllers.

This also ensures that everything shown is consistently coming
from the leading master, specifically, now the log viewer shows
the leading master's log (and the UI messaging is updated in this
patch accordingly).

Having this logic in just one place makes it easier to modify it,
e.g., to make it possible to use the UI via a reverse proxy.

Diffs (updated)

  src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b 
  src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc 




manual testing


Benjamin Mahler

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message