mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66870: Added per-framework metrics for suppressed roles.
Date Tue, 31 Jul 2018 18:59:08 GMT


> On July 25, 2018, 11:58 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 734-758 (original), 747-772 (patched)
> > <https://reviews.apache.org/r/66870/diff/6/?file=2063434#file2063434line747>
> >
> >     I'm not familiar with this, but it reads as wrong. Why does clearing the agent
filters modify the framework's suppressed roles? That breaks the API contract in which frameworks
are in control of their suppression state.
> >     
> >     I don't think we should tweak their suppression state based on events, we should
instead expose those events to schedulers and let them decide.
> >     
> >     Can you follow up with a ticket / fix for this or ask (benno i think?) to follow
up?

I've posted a patch at the end of this chain to address this issue: https://reviews.apache.org/r/68134/

Thanks for bringing this up, bmahler!!


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66870/#review206482
-----------------------------------------------------------


On July 26, 2018, 6:31 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66870/
> -----------------------------------------------------------
> 
> (Updated July 26, 2018, 6:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per-framework metrics for suppressed roles.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 7b4e9db3435b51c9ce025b7b522e10db4b907ebb

>   src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
>   src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36 
> 
> 
> Diff: https://reviews.apache.org/r/66870/diff/7/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message