mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 68134: Avoided reviving on behalf of scheduler after agent reconfiguration.
Date Tue, 31 Jul 2018 18:57:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68134/
-----------------------------------------------------------

Review request for mesos, Benno Evers and Benjamin Mahler.


Bugs: MESOS-9124
    https://issues.apache.org/jira/browse/MESOS-9124


Repository: mesos


Description
-------

When agent reconfiguration was enabled in Mesos, the allocator was
also updated to remove all offer filters associated with an agent when
that agent's attributes change. In addition, whenever filters for an
agent are removed, the framework is revived for all roles that it is
registered in.

While this ensures that schedulers will have an opportunity to use
resources on an agent after reconfiguration, modifying the scheduler's
suppression may put the scheduler in an inconsistent state, where it
believes it is suppressed in a particular role when it is not.

This patch eliminates the suppression modification code, while
keeping the code which removes a reconfigured agent's offer filters.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp 35992474eacb8b14ae57e1dc23307e1542f63cb5 


Diff: https://reviews.apache.org/r/68134/diff/1/


Testing
-------

`make check`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message