mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68094: Add port mapping and network ports isolators sources to CMake.
Date Tue, 31 Jul 2018 08:15:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68094/#review206645
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On July 27, 2018, 9:11 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68094/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 9:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph
Wu.
> 
> 
> Bugs: MESOS-8993 and MESOS-8994
>     https://issues.apache.org/jira/browse/MESOS-8993
>     https://issues.apache.org/jira/browse/MESOS-8994
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds the relevant options and source files, but with a fatal
> message if they're used, as we do not yet check for their
> dependencies. This also adds the `mesos-network-helper` executable as
> used by the port mapping isolator.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
>   src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
>   src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8

>   src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 
> 
> 
> Diff: https://reviews.apache.org/r/68094/diff/4/
> 
> 
> Testing
> -------
> 
> Pending... There isn't much to test for the isolators added, as they're added with a
fatal bailout. Double-checking that without enabling the new options, everything still works
as expected.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message