mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 68120: UI: Pull up the leader URL generation to a top-level function.
Date Tue, 31 Jul 2018 02:40:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68120/
-----------------------------------------------------------

Review request for mesos, Armand Grillet and Gastón Kleiman.


Repository: mesos


Description
-------

This path pulls up the leader URL prefix generation to a top-level
function in order to have it re-used across controllers.

Having this logic in just one place makes it easier to modify it,
e.g., to make it possible to use the UI via a reverse proxy.


Diffs
-----

  src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b 
  src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc 


Diff: https://reviews.apache.org/r/68120/diff/1/


Testing
-------

manual testing


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message