mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67187: Tested per-framework task state metrics.
Date Tue, 31 Jul 2018 00:23:24 GMT


> On July 25, 2018, 9:06 p.m., Gastón Kleiman wrote:
> > src/tests/master_tests.cpp
> > Lines 9113-9117 (patched)
> > <https://reviews.apache.org/r/67187/diff/4/?file=2061407#file2061407line9113>
> >
> >     Can we use the new helpers here?
> >     
> >     ```
> >       testing::Sequence taskSequence1;
> >       Future<TaskStatus> running1;
> >     
> >       EXPECT_CALL(
> >           sched,
> >           statusUpdate(&driver, AllOf(
> >               TaskStatusTaskIdEq(task1.id()),
> >               TaskStatusStateEq(TASK_STARTING))))
> >         .InSequence(taskSequence1)
> >         
> >       EXPECT_CALL(
> >          sched,
> >          statusUpdate(&driver, AllOf(
> >              TaskStatusTaskIdEq(task1.id()),
> >              TaskStatusStateEq(TASK_RUNNING))))
> >        .InSequence(taskSequence1)
> >        .WillOnce(FutureArg<1>(&running1));
> >     ```

Thx for this suggestion!!


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67187/#review206466
-----------------------------------------------------------


On July 31, 2018, 12:22 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67187/
> -----------------------------------------------------------
> 
> (Updated July 31, 2018, 12:22 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Gilbert Song.
> 
> 
> Bugs: MESOS-8847
>     https://issues.apache.org/jira/browse/MESOS-8847
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds `MasterTest.TaskStateMetrics`, which verifies that
> per-framework task state metrics for both terminal and active task
> states report correct values, even after agent reregistration.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 
> 
> 
> Diff: https://reviews.apache.org/r/67187/diff/7/
> 
> 
> Testing
> -------
> 
> The new test was run ~10,000 times with no failures.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message