mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68092: CMake: Always build gRPC in Mesos.
Date Mon, 30 Jul 2018 10:16:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68092/#review206593
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/CMakeLists.txt
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/68092/#comment289595>

    Any reason we cannot just merge this patch with https://reviews.apache.org/r/68074/?



src/cmake/MesosProtobuf.cmake
Line 145 (original), 145 (patched)
<https://reviews.apache.org/r/68092/#comment289593>

    I couldn't find out how `PROTOC_GRPC` is set and wheter it can ever be false. Do we still
need this conditional?
    
    Here and below.


- Benjamin Bannier


On July 27, 2018, 9:12 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68092/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 9:12 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8395
>     https://issues.apache.org/jira/browse/MESOS-8395
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Always build gRPC in Mesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 9b0dfe0ab2187d6d57bb267939aa7c1dbf6c3e8d 
>   cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
>   src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
>   src/cmake/MesosProtobuf.cmake 9fadc9f0616a00f3c30c1fa81a44e0023ccf865f 
>   src/examples/CMakeLists.txt 6a6ee7c3029552ef12726d1c36ccabd8c79ba1f8 
>   src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 
> 
> 
> Diff: https://reviews.apache.org/r/68092/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check with CMake
> Built with Ninja
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message