mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68074: Autotools: Always build gRPC in Mesos.
Date Mon, 30 Jul 2018 10:16:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68074/#review206589
-----------------------------------------------------------


Fix it, then Ship it!





cmake/CompilationConfigure.cmake
Line 80 (original), 80 (patched)
<https://reviews.apache.org/r/68074/#comment289590>

    If you want to keep separate patches for modifying autotools and cmake, this should be
in the next patch in the chain, https://reviews.apache.org/r/68092/.



configure.ac
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/68074/#comment289598>

    Any reason we cannot just merge this patch with https://reviews.apache.org/r/68092/?



src/Makefile.am
Line 1529 (original), 1521 (patched)
<https://reviews.apache.org/r/68074/#comment289591>

    Can we merge this with above list now?


- Benjamin Bannier


On July 27, 2018, 9:12 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68074/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 9:12 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8395
>     https://issues.apache.org/jira/browse/MESOS-8395
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Autotools: Always build gRPC in Mesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339 
>   cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
>   configure.ac 58003b6e823c8457f4b5a8c8d670be43bf96de8d 
>   include/csi/spec.hpp 2e9b870617a6604e5d3e93eedce119ec029eea05 
>   src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9 
>   src/python/native_common/ext_modules.py.in dc4d91a8b8e3640e2191a53e657a5e4588fa911e

>   src/resource_provider/local.cpp ae23c2000b7941aad92d3b83e4e905bdf042ebe8 
> 
> 
> Diff: https://reviews.apache.org/r/68074/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message