mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.
Date Sun, 29 Jul 2018 14:47:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206577
-----------------------------------------------------------




CHANGELOG
Lines 12 (patched)
<https://reviews.apache.org/r/68067/#comment289559>

    s/Agent/agent/



CHANGELOG
Lines 13 (patched)
<https://reviews.apache.org/r/68067/#comment289560>

    If we only garbage collect sandboxes created via the LAUNCH_NESTED_CONTAINER API, should
we name this flag `--gc_nested_container_sandboxes`? Or we want this flag to cover standalone
container in future?



docs/configuration/agent.md
Lines 892 (patched)
<https://reviews.apache.org/r/68067/#comment289566>

    s/container/nested container/



docs/operator-http-api.md
Lines 3592 (patched)
<https://reviews.apache.org/r/68067/#comment289561>

    s/Agent/agent/



docs/operator-http-api.md
Lines 3594-3595 (patched)
<https://reviews.apache.org/r/68067/#comment289565>

    A newline between? Or we could merge these two paragraphs into one.



docs/operator-http-api.md
Lines 3595 (patched)
<https://reviews.apache.org/r/68067/#comment289563>

    Besides this change, I think we also need to add this flag into the output of the agent
API `GET_FLAGS` in this doc.



docs/operator-http-api.md
Lines 3596 (patched)
<https://reviews.apache.org/r/68067/#comment289562>

    s/Agent/agent/



src/slave/flags.cpp
Lines 469 (patched)
<https://reviews.apache.org/r/68067/#comment289567>

    Ditto.


- Qian Zhang


On July 28, 2018, 8:22 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> -----------------------------------------------------------
> 
> (Updated July 28, 2018, 8:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
>     https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.
> 
> This also updates some documentation and recommends enabling this flag
> when the user uses the same default executor to launch multiple tasks.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 1ef4fe3de8865eb05a2a10ab16fa2cd37d5236fb 
>   docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7 
>   docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7 
>   docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13 
>   docs/upgrades.md f3cf0b06fcc4dfa012f44f9cab28f9674b1b8b43 
>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
>   src/slave/http.cpp ab5864d9fd2fde478ed7da2ca7ed8abedc72c7c5 
> 
> 
> Diff: https://reviews.apache.org/r/68067/diff/3/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message