mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes.
Date Sun, 29 Jul 2018 14:34:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68095/#review206578
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Lines 906 (patched)
<https://reviews.apache.org/r/68095/#comment289568>

    s/sandboxes/sandbox/



src/slave/containerizer/mesos/containerizer.cpp
Lines 910-912 (patched)
<https://reviews.apache.org/r/68095/#comment289569>

    Do we really need `containerId.has_parent()` here? I think the file `terminationPath`
existing means this must be a nested container since we create `TERMINATION_FILE` only for
nested container. So maybe this should be a check (`CHECK(containerId.has_parent())`)?



src/slave/containerizer/mesos/containerizer.cpp
Lines 916 (patched)
<https://reviews.apache.org/r/68095/#comment289570>

    Do we need to make sure `directory` exists before gc it? Otherwise, we may gc the same
dir again even after it has been removed by gc.



src/slave/containerizer/mesos/containerizer.cpp
Lines 2743-2753 (patched)
<https://reviews.apache.org/r/68095/#comment289571>

    Can we merge these code into the above `if (containerId.has_parent()) {`?


- Qian Zhang


On July 28, 2018, 8:22 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68095/
> -----------------------------------------------------------
> 
> (Updated July 28, 2018, 8:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
>     https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the --gc_non_executor_container_sandboxes agent flag is enabled,
> this commit changes the MesosContainerizer to schedule nested container
> sandboxes for garbage collection.  The GC policy is the same between
> the MesosContainerizer and the Agent.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b

>   src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a

> 
> 
> Diff: https://reviews.apache.org/r/68095/diff/1/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message