mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.
Date Sat, 28 Jul 2018 00:31:35 GMT


> On July 27, 2018, 9:37 a.m., Qian Zhang wrote:
> > I'd prefer to split this patch into two, one for adding the new flag and updating
the related docs, and another for updating the containerizer's code.

The containerizer code changes have been moved into: https://reviews.apache.org/r/68095/


> On July 27, 2018, 9:37 a.m., Qian Zhang wrote:
> > src/slave/flags.hpp
> > Lines 92 (patched)
> > <https://reviews.apache.org/r/68067/diff/1/?file=2064443#file2064443line92>
> >
> >     We also need to add this flag into `Http::STATE_HELP()` and a couple of docs,
e.g., `agent.md`, `operator-http-api.md`, `sandbox.md`, `upgrade.md` and `CHANGELOG`.

Good idea.  I've updated the review with changes to all those.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206538
-----------------------------------------------------------


On July 27, 2018, 5:22 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 5:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
>     https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.
> 
> This also updates some documentation and recommends enabling this flag
> when the user uses the same default executor to launch multiple tasks.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 1ef4fe3de8865eb05a2a10ab16fa2cd37d5236fb 
>   docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7 
>   docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7 
>   docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13 
>   docs/upgrades.md f3cf0b06fcc4dfa012f44f9cab28f9674b1b8b43 
>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
>   src/slave/http.cpp ab5864d9fd2fde478ed7da2ca7ed8abedc72c7c5 
> 
> 
> Diff: https://reviews.apache.org/r/68067/diff/3/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message