mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 68053: Call any function in a specified namespace.
Date Fri, 27 Jul 2018 22:13:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68053/#review206558
-----------------------------------------------------------




src/linux/ns.hpp
Lines 201 (patched)
<https://reviews.apache.org/r/68053/#comment289525>

    period at the end of a comment. see style guide. Fix all occurances.



src/linux/ns.hpp
Lines 227-228 (patched)
<https://reviews.apache.org/r/68053/#comment289526>

    can we do the following?
    ```
    promise->set(func());
    ```



src/linux/ns.hpp
Lines 243 (patched)
<https://reviews.apache.org/r/68053/#comment289527>

    I think there's a race here. It's possible that some one is deleting `NamespaceRunner`.
It triggers the destructor `~NamespaceRunner` first. Assuming there T1 is the thread that's
doing the `delete`, and T2 is the looper thread.
    
    ```
    [T2] while (queue). Enter the loop body
    [T1] queue.reset() in ~NamespaceRunner
    [T2] queue->get() segfault
    ```



src/tests/containerizer/ns_tests.cpp
Line 268 (original), 268 (patched)
<https://reviews.apache.org/r/68053/#comment289521>

    nits: 2 lines apart according to mesos style guide



src/tests/containerizer/ns_tests.cpp
Lines 274 (patched)
<https://reviews.apache.org/r/68053/#comment289522>

    nits: period at the end of each comment according to style guide



src/tests/containerizer/ns_tests.cpp
Lines 277 (patched)
<https://reviews.apache.org/r/68053/#comment289523>

    Ditto on period.



src/tests/containerizer/ns_tests.cpp
Lines 286 (patched)
<https://reviews.apache.org/r/68053/#comment289524>

    Ditto on period.


- Jie Yu


On July 27, 2018, 8:35 p.m., Sergey Urbanovich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68053/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 8:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
>     https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The NamespaceRunner runs any function in a specified namespace. To do
> that it manages a separate thread which would be re-associated with
> that namespace.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 0b4136bd3cc2d3e0cfee163d89469558e699b5f2 
>   src/tests/containerizer/ns_tests.cpp fa4349e29b975550e05b00a1f848a24cd8e4f0de 
> 
> 
> Diff: https://reviews.apache.org/r/68053/diff/2/
> 
> 
> Testing
> -------
> 
> bin/mesos-tests.sh --verbose --gtest_filter="NsTest*" --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message