mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.
Date Fri, 27 Jul 2018 16:37:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206538
-----------------------------------------------------------



I'd prefer to split this patch into two, one for adding the new flag and updating the related
docs, and another for updating the containerizer's code.


src/slave/flags.hpp
Lines 92 (patched)
<https://reviews.apache.org/r/68067/#comment289504>

    We also need to add this flag into `Http::STATE_HELP()` and a couple of docs, e.g., `agent.md`,
`operator-http-api.md`, `sandbox.md`, `upgrade.md` and `CHANGELOG`.


- Qian Zhang


On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 3:01 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
>     https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.  Garbage collection follows the same
> policy as the agent (as defined by --gc_delay and --gc_disk_headroom).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b

>   src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a

>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
> 
> 
> Diff: https://reviews.apache.org/r/68067/diff/1/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message