mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67878: Updated tests to check per-framework metrics.
Date Thu, 26 Jul 2018 20:00:04 GMT


> On July 25, 2018, 6:50 p.m., Gastón Kleiman wrote:
> > src/tests/master_tests.cpp
> > Lines 6109 (patched)
> > <https://reviews.apache.org/r/67878/diff/2-5/?file=2061406#file2061406line6111>
> >
> >     Ditto using a single metrics object per test.
> >     
> >     We should also test that the value of this metrics is 0 before launching the
task.

I think I'll keep these as-is for consistency.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67878/#review206460
-----------------------------------------------------------


On July 25, 2018, 3:36 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67878/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 3:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated tests to check per-framework metrics.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 44b0ac39f87c6415e130c5e7f505428642739311 
>   src/tests/scheduler_tests.cpp bcdd0ec010889b4155a0feebe0248b7593d8bf0c 
> 
> 
> Diff: https://reviews.apache.org/r/67878/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Also ran in internal CI pipeline, tests were green on all platforms.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message