mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 68066: Shared GC actor between Agent and MesosContainerizer.
Date Thu, 26 Jul 2018 19:01:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68066/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Qian Zhang.


Bugs: MESOS-7947
    https://issues.apache.org/jira/browse/MESOS-7947


Repository: mesos


Description
-------

This inserts the pointer to the GC actor into the MesosContainerizer,
so the containerizer can schedule sandboxes it manages for GC according
to the agent's GC policy.  The Composing/Docker Containerizers are
unchanged as they do not directly deal with nested or standalone
containers.

To minimize test changes, the GC actor argument defaults to nullptr.
Only tests that exercise sandbox GC will need to supply the actor.


Diffs
-----

  src/local/local.cpp 5b7bb59576cfc7c0c7b5e438fee1d2703c7fad2f 
  src/slave/containerizer/containerizer.hpp 675dfade265fe9fdd0e8649e918f5ff4e370629f 
  src/slave/containerizer/containerizer.cpp 59f107af1c08877dedd0597d0f60123940927ab0 
  src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b

  src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a

  src/slave/main.cpp 489e87522588be259d382f588b66907ba29f1788 
  src/tests/cluster.cpp cb7d3f0298dfa8c11634d6674f93f2f355b48a53 
  src/tests/containerizer/environment_secret_isolator_tests.cpp 7a516e5da7053971e0d7dbac29cdfc34eb04bfd5

  src/tests/containerizer/mesos_containerizer_tests.cpp 1b8e53ca1bcd454a3e80c010181c0fddd8825b7e



Diff: https://reviews.apache.org/r/68066/diff/1/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message