mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66870: Added per-framework metrics for suppressed roles.
Date Thu, 26 Jul 2018 18:31:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66870/
-----------------------------------------------------------

(Updated July 26, 2018, 6:31 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.


Changes
-------

Addressed comments, and changed the names of `addRole` and `removeRole` methods to avoid ambiguity.


Repository: mesos


Description
-------

Added per-framework metrics for suppressed roles.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp 7b4e9db3435b51c9ce025b7b522e10db4b907ebb 
  src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66870/diff/7/

Changes: https://reviews.apache.org/r/66870/diff/6-7/


Testing
-------

Testing details can be found at the end of this chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message