mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68061: Eliminated unnecessary copy in DataEncoder constructor.
Date Thu, 26 Jul 2018 16:20:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68061/#review206507
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On July 26, 2018, 10:17 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68061/
> -----------------------------------------------------------
> 
> (Updated July 26, 2018, 10:17 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With C++11, we can rely on move semantics to save one copy
> of the to-be-encoded data.
> 
> Additionally, removed an unnecessary forward declaration.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/encoder.hpp 70b5ec479e90c0eb6ac729b465739b581729a956 
> 
> 
> Diff: https://reviews.apache.org/r/68061/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message