mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67889: Installed google's signal handler for libprocess benchmarks.
Date Wed, 25 Jul 2018 20:19:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67889/#review206462
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On July 11, 2018, 10:51 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67889/
> -----------------------------------------------------------
> 
> (Updated July 11, 2018, 10:51 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will provide a stack trace if the benchmarks crash, the
> approach here was followed from the libprocess test main.cpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b

> 
> 
> Diff: https://reviews.apache.org/r/67889/diff/1/
> 
> 
> Testing
> -------
> 
> Ran with a crash, and obtained the stack trace.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message