mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66856: Tracked completed framework metrics in the allocator.
Date Wed, 25 Jul 2018 15:37:07 GMT


> On July 19, 2018, 10:50 p.m., Gastón Kleiman wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 346-350 (patched)
> > <https://reviews.apache.org/r/66856/diff/6/?file=2061394#file2061394line346>
> >
> >     This looks good, but the framework removal flow is not straightforward. I'd
feel much more confident in the change if there was a test that verifies that completed frameworks
are evicted once `max_completed_frameworks` is reached.
> >     
> >     The test could start a master with `--max_completed_frameworks=2`, register
three frameworks and then check the metrics.
> >     
> >     I think you could add that test to https://reviews.apache.org/r/67878/ or in
a new patch.

I ended up updating the existing test for the `max_completed_frameworks` flag to validate
the metrics as well; it's in this patch: https://reviews.apache.org/r/67878/


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66856/#review206252
-----------------------------------------------------------


On July 24, 2018, 5:30 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66856/
> -----------------------------------------------------------
> 
> (Updated July 24, 2018, 5:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This ensures that per-framework metrics which are tracked in the
> allocator will be retained as long as the per-framework metrics
> which are tracked in the master.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp c19ab64ff1422a68cfb6eecea7e2cc4132da8dcc 
>   src/master/allocator/mesos/allocator.hpp 4c337470c5722a5bd1f53c67b5d81a497a7b8023 
>   src/master/allocator/mesos/hierarchical.hpp c1a6789f1808a57dd94ede7bbd2636031f136ea3

>   src/master/allocator/mesos/hierarchical.cpp 7b4e9db3435b51c9ce025b7b522e10db4b907ebb

>   src/master/master.cpp 2af976f7ea7f81d4b06a45ce13286dbd61b9b144 
>   src/tests/allocator.hpp 6139492bf4d18f31e558bd0216bcccd2705af4d7 
>   src/tests/api_tests.cpp 182622a62d350ebefc891a385de3f2d35a7c0243 
>   src/tests/master_allocator_tests.cpp 9d802c8ba04374ac6df7aac668bcf05d5eb6c407 
>   src/tests/master_quota_tests.cpp d4a8db8b34bcd6793af024e998054b795e900832 
>   src/tests/reservation_tests.cpp 6ae0055ad3ca2f848c613a293177d02b3140355e 
>   src/tests/resource_offers_tests.cpp 6e24cddce65e7f5a0ce8ea4fde8397a19236d8b8 
>   src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e 
> 
> 
> Diff: https://reviews.apache.org/r/66856/diff/8/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message