mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 67826: Made `Slave::getAvailable()` return all shared resources.
Date Fri, 20 Jul 2018 23:30:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67826/
-----------------------------------------------------------

(Updated July 20, 2018, 4:30 p.m.)


Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Changes
-------

Rebased.


Bugs: MESOS-9104
    https://issues.apache.org/jira/browse/MESOS-9104


Repository: mesos


Description
-------

Currently, depending on already allocated resources,
`HierarchicalAllocatorProcess::Slave::getAvailable()`
may not contain all the shared resources.
Thus it does not accurately reflect what is available.

Since shared resources are always allocatable, we should
include all shared resources in the agent available resources.
This would help remove the one off logic for removing and
adding back shared resources in the allocation loop.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 702e7c0aa84b4b672d82c759c25a28a77c78ad50 


Diff: https://reviews.apache.org/r/67826/diff/3/

Changes: https://reviews.apache.org/r/67826/diff/2-3/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message