mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66856: Tracked completed framework metrics in the allocator.
Date Fri, 20 Jul 2018 20:58:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66856/
-----------------------------------------------------------

(Updated July 20, 2018, 8:58 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.


Changes
-------

Rebase to accommodate our new usage of the `override` keyword.


Repository: mesos


Description
-------

This ensures that per-framework metrics which are tracked in the
allocator will be retained as long as the per-framework metrics
which are tracked in the master.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp c19ab64ff1422a68cfb6eecea7e2cc4132da8dcc 
  src/master/allocator/mesos/allocator.hpp 4c337470c5722a5bd1f53c67b5d81a497a7b8023 
  src/master/allocator/mesos/hierarchical.hpp 702e7c0aa84b4b672d82c759c25a28a77c78ad50 
  src/master/allocator/mesos/hierarchical.cpp 707dd6bd0f255a64d759ce87cbf75be57d86b392 
  src/master/master.cpp 2af976f7ea7f81d4b06a45ce13286dbd61b9b144 
  src/tests/allocator.hpp 6139492bf4d18f31e558bd0216bcccd2705af4d7 
  src/tests/api_tests.cpp 182622a62d350ebefc891a385de3f2d35a7c0243 
  src/tests/master_allocator_tests.cpp 9d802c8ba04374ac6df7aac668bcf05d5eb6c407 
  src/tests/master_quota_tests.cpp d4a8db8b34bcd6793af024e998054b795e900832 
  src/tests/reservation_tests.cpp 6ae0055ad3ca2f848c613a293177d02b3140355e 
  src/tests/resource_offers_tests.cpp 6e24cddce65e7f5a0ce8ea4fde8397a19236d8b8 
  src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e 


Diff: https://reviews.apache.org/r/66856/diff/7/

Changes: https://reviews.apache.org/r/66856/diff/6-7/


Testing
-------

Testing details can be found at the end of this chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message