mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 67989: Fixed issues with the JSON serialization tests.
Date Fri, 20 Jul 2018 11:17:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67989/#review206278
-----------------------------------------------------------


Ship it!




Ship It!

- Benno Evers


On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67989/
> -----------------------------------------------------------
> 
> (Updated July 20, 2018, 3:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benno Evers.
> 
> 
> Bugs: MESOS-9092
>     https://issues.apache.org/jira/browse/MESOS-9092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There were some issues in the existing JSON serialization tests
> when it comes to rapidjson. For example:
> 
>   - 0x7F does not need to be escaped per ECMA-404. This is what
>     rapidjson adheres to.
>   - Forward slash does not need to be escaped.
> 
> This updates the test to have a valid UTF-8 case with a multi-byte
> sequence (which does not need to be escaped per ECMA-404), as well
> as an invalid case where a multibyte sequence is partial (which we
> allow for now since we do not have validation errors exposed).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/json_tests.cpp 508d8433797a81ec7f720ddc678a007297fec5b3 
>   3rdparty/stout/tests/jsonify_tests.cpp 7de95a4a15912fae3c9269733758e765abc7330d 
> 
> 
> Diff: https://reviews.apache.org/r/67989/diff/1/
> 
> 
> Testing
> -------
> 
> Tested at the end of this chain, since this is split across stout/libprocess/mesos.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message