mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 67992: Avoid performance cost of ostringstream in http::OK json constructors.
Date Fri, 20 Jul 2018 03:39:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67992/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Benno Evers.


Repository: mesos


Description
-------

In the common case where no jsonp is passed this avoids an extra copy
out from the ostringstream. In the jsonp case, the performance should
be near identical or better as we now pre-reserve the space needed
for the body.


Diffs
-----

  3rdparty/libprocess/src/http.cpp cbb910282a4aff8a914dbd13ff20fc70d929c269 


Diff: https://reviews.apache.org/r/67992/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message