mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 67990: Fixed libprocess tests against rapidjson.
Date Fri, 20 Jul 2018 03:38:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67990/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Benno Evers.


Bugs: MESOS-9092
    https://issues.apache.org/jira/browse/MESOS-9092


Repository: mesos


Description
-------

The libprocess tests were checking the serialized format of metrics,
which previously escaped forward slashes. However, this is not what
rapidjson does and it's also valid json according to ECMA-404.


Diffs
-----

  3rdparty/libprocess/src/tests/metrics_tests.cpp 8590bdb4da1bead462a5b91c23bbc31905e57a47



Diff: https://reviews.apache.org/r/67990/diff/1/


Testing
-------

Tested at the end of this chain, since this is split across stout/libprocess/mesos.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message