mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 67878: Added/updated tests to check per-framework metrics.
Date Thu, 19 Jul 2018 23:27:12 GMT


> On July 19, 2018, 3:45 p.m., Gastón Kleiman wrote:
> > Can you add a test that verifies whether allocator and non-allocator per-framework
metrics are evicted once the `max_completed_frameworks` bound is reached?

And also one testing the `suppressed` metric.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67878/#review206251
-----------------------------------------------------------


On July 17, 2018, 6:46 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67878/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 6:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added/updated tests to check per-framework metrics.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 
> 
> 
> Diff: https://reviews.apache.org/r/67878/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message