mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 66870: Added per-framework metrics for suppressed roles.
Date Thu, 19 Jul 2018 23:09:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66870/#review206253
-----------------------------------------------------------



Can you add a test? At least one that calls suppress/revive, but ideally also one that adds
and removes roles.


src/master/allocator/mesos/hierarchical.cpp
Line 489 (original), 498 (patched)
<https://reviews.apache.org/r/66870/#comment289157>

    We need to call `FrameworkMetrics::addRole()` here.
    
    Ditto `FrameworkMetrics::removeRole()` in the corresponding place.


- Gastón Kleiman


On July 17, 2018, 6:45 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66870/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 6:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per-framework metrics for suppressed roles.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b

>   src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
>   src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36 
> 
> 
> Diff: https://reviews.apache.org/r/66870/diff/5/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message