mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.
Date Thu, 19 Jul 2018 20:41:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67951/
-----------------------------------------------------------

(Updated July 19, 2018, 1:41 p.m.)


Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.


Changes
-------

Removed const member so that it can be default copy constructed.


Bugs: MESOS-5817 and MESOS-5904
    https://issues.apache.org/jira/browse/MESOS-5817
    https://issues.apache.org/jira/browse/MESOS-5904


Repository: mesos


Description
-------

This defaults to `os::PATH_SEPARATOR` and so by default retains the
previous behavior. However, now `Path` can be arbitrarily used with,
e.g., URLs on Windows by providing `/` as the separator.


Diffs (updated)
-----

  3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d 


Diff: https://reviews.apache.org/r/67951/diff/3/

Changes: https://reviews.apache.org/r/67951/diff/2-3/


Testing
-------

`stout-tests` and `libprocess-tests` passed on Windows and Ubuntu


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message