mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 67809: Added per-framework metrics for scheduler events.
Date Wed, 18 Jul 2018 23:38:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/#review206226
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp
Lines 2473 (patched)
<https://reviews.apache.org/r/67809/#comment289113>

    Nit: s/message/the message/ ?



src/master/metrics.cpp
Lines 585-587 (patched)
<https://reviews.apache.org/r/67809/#comment289114>

    Nit: I think I prefer adding the aggregate counter (`events`) and the per-type counters
together, similar to how the destructor is structured.
    
    But both ways are readable, so feel free to drop this issue =).


- Gastón Kleiman


On July 17, 2018, 6:34 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67809/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 6:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilbert
Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-8844
>     https://issues.apache.org/jira/browse/MESOS-8844
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per-framework metrics for scheduler events.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67809/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message