mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 67968: Added logging to some containerizer destroy paths.
Date Wed, 18 Jul 2018 20:48:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67968/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Repository: mesos


Description
-------

While we currently log when we start destroying a container or
provisioned volumes, we do not log when the destroy is done. This
makes it hard to understand how dependent destroy operations, e.g.,
involving nested containers, could interact.

This patch adds logging when a mesos or docker containerizer, or
provisioner destroy path ends.


Diffs
-----

  src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5 
  src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a

  src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870



Diff: https://reviews.apache.org/r/67968/diff/1/


Testing
-------

Since this patch just adds logging, it is almost a non-functional change. Ran `make check`
anyway.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message