mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67187: Tested per-framework task state metrics.
Date Wed, 18 Jul 2018 01:46:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67187/
-----------------------------------------------------------

(Updated July 18, 2018, 1:46 a.m.)


Review request for mesos, Gastón Kleiman and Gilbert Song.


Changes
-------

Updated metric keys.


Bugs: MESOS-8847
    https://issues.apache.org/jira/browse/MESOS-8847


Repository: mesos


Description
-------

This patch adds `MasterTest.TaskStateMetrics`, which verifies that
per-framework task state metrics for both terminal and active task
states report correct values, even after agent reregistration.


Diffs (updated)
-----

  src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 


Diff: https://reviews.apache.org/r/67187/diff/4/

Changes: https://reviews.apache.org/r/67187/diff/3-4/


Testing
-------

The new test was run ~10,000 times with no failures.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message