mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 67875: Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`.
Date Wed, 18 Jul 2018 01:08:55 GMT


> On July 16, 2018, 8:28 p.m., Gastón Kleiman wrote:
> > src/master/metrics.cpp
> > Lines 551-554 (patched)
> > <https://reviews.apache.org/r/67875/diff/1/?file=2057444#file2057444line551>
> >
> >     Per offline discussion we can inline this method in `getFrameworkMetricPrefix()`.

I've rolled this patch into the subsequent one.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67875/#review206120
-----------------------------------------------------------


On July 10, 2018, 3:39 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67875/
> -----------------------------------------------------------
> 
> (Updated July 10, 2018, 3:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`.
> 
> 
> Diffs
> -----
> 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67875/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message