mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Radhika Jandhyala via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.
Date Tue, 17 Jul 2018 23:27:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67951/#review206181
-----------------------------------------------------------


Ship it!




Ship It!

- Radhika Jandhyala


On July 17, 2018, 10:27 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67951/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 10:27 p.m.)
> 
> 
> Review request for mesos, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika
Jandhyala.
> 
> 
> Bugs: MESOS-5904 and MESOS-8564
>     https://issues.apache.org/jira/browse/MESOS-5904
>     https://issues.apache.org/jira/browse/MESOS-8564
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This defaults to `os::PATH_SEPARATOR` and so by default retains the
> previous behavior. However, now `Path` can be arbitrarily used with,
> e.g., URLs on Windows by providing `/` as the separator.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d 
> 
> 
> Diff: https://reviews.apache.org/r/67951/diff/1/
> 
> 
> Testing
> -------
> 
> `stout-tests` and `libprocess-tests` passed on Windows and Ubuntu
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message