mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67947: Passed the default options when making gRPC calls.
Date Tue, 17 Jul 2018 20:35:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67947/#review206168
-----------------------------------------------------------


Ship it!




Nice!

Note that if we always wanted compilable commits, we could commit r/67938 with a default argument,
then add explicit arguments for all users in this patch, and finally remove the default argument
in a cleanup. That sounds like the overkill it is :D

- Benjamin Bannier


On July 17, 2018, 10:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67947/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 10:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9055
>     https://issues.apache.org/jira/browse/MESOS-9055
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Passed the default options when making gRPC calls.
> 
> 
> Diffs
> -----
> 
>   src/csi/client.cpp a36e6228f39405f729e347db51ccd95c5fb76cdb 
> 
> 
> Diff: https://reviews.apache.org/r/67947/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message