mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67928: Added balloon framework metric for tasks which were running.
Date Mon, 16 Jul 2018 22:01:53 GMT


> On July 16, 2018, 8:34 p.m., Meng Zhu wrote:
> > src/examples/balloon_framework.cpp
> > Lines 304 (patched)
> > <https://reviews.apache.org/r/67928/diff/1/?file=2059606#file2059606line308>
> >
> >     stati --> statistics?

This was supposed to be a plural of _status_ which of cause is _status_ (that's a long _u_),
but I completely messed it up. I went with _status updates_ for now to avoid _statuses_.


> On July 16, 2018, 8:34 p.m., Meng Zhu wrote:
> > src/examples/balloon_framework.cpp
> > Lines 309 (patched)
> > <https://reviews.apache.org/r/67928/diff/1/?file=2059606#file2059606line313>
> >
> >     ditto

Ditto.


> On July 16, 2018, 8:34 p.m., Meng Zhu wrote:
> > src/examples/balloon_framework.cpp
> > Line 304 (original), 316 (patched)
> > <https://reviews.apache.org/r/67928/diff/1/?file=2059606#file2059606line320>
> >
> >     Let's add back the default.

I explicitly enumerated all possible cases here to forcibly trigger compiler errors should
we add another task status. This is usually what we prefer in the code if possible.

Dropping.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67928/#review206114
-----------------------------------------------------------


On July 17, 2018, 12:01 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67928/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 12:01 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The framework currently exposes metric counters for various expected
> and unexpected task termination reasons. Interpreting these counters
> can be non-trivial since tasks might fail due to benign, but unknown
> external reasons.
> 
> This patch adds a counter for the tasks which actually made it to the
> running stage which can be correlated with the different terminal task
> counts.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
> 
> 
> Diff: https://reviews.apache.org/r/67928/diff/2/
> 
> 
> Testing
> -------
> 
> Started the framework with a `local` master and examine the metric.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message