mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 67927: Removed potentially unneeded lambda capture.
Date Mon, 16 Jul 2018 19:26:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67927/#review206117
-----------------------------------------------------------


Ship it!




Looks good and thanks for a great comment!

- Benjamin Hindman


On July 16, 2018, 7:22 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67927/
> -----------------------------------------------------------
> 
> (Updated July 16, 2018, 7:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dario Rexin.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In some instances variables used in the body of a lambda do not need
> to be captured explicitly, see e.g.,
> https://stackoverflow.com/a/43468519/176922. Support for this across
> compiler vendors seems to be incomplete at this point; while e.g.,
> clang emits a warning (which we potentially turn into a fatal error)
> for this, msvc still seems to require such variables to be captured.
> 
> To provide a warning free build this patch moves from the usually
> preferred explicit capture list to an implicit capture by reference.
> This allows us to capture all needed variables correctly without
> having to capture too much.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp e8ef21fd9c203ac5e10c17694393322151231435

> 
> 
> Diff: https://reviews.apache.org/r/67927/diff/3/
> 
> 
> Testing
> -------
> 
> Tested on a number of platforms and compilers in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message