mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67927: Removed unneeded lambda capture.
Date Mon, 16 Jul 2018 13:45:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67927/#review206100
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67927']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1930/mesos-review-67927

Relevant logs:

- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1930/mesos-review-67927/logs/libprocess-tests-cmake-stdout.log):

```
         cl : Command line warning D9002: ignoring unknown option '-fPIC' [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1415):
warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520):
warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689):
warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2280):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2292):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2301):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         cl : Command line warning D9002: ignoring unknown option '-fPIC' [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1415):
warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520):
warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689):
warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2280):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2292):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2301):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
         d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target)
(1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (3)
->
       (ClCompile target) -> 
         d:\dcos\mesos\mesos\3rdparty\libprocess\src\tests\benchmarks.cpp(720): error C3493:
'messageCount' cannot be implicitly captured because no default capture mode has been specified
[D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]

    18 Warning(s)
    1 Error(s)

Time Elapsed 00:02:07.27
```

- Mesos Reviewbot Windows


On July 16, 2018, 12:37 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67927/
> -----------------------------------------------------------
> 
> (Updated July 16, 2018, 12:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dario Rexin.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In some instances variables used in the body of a lambda do not need
> to be captured explicitly. This patch removes the unneeded capture of
> a constant integer initialized with a compile-time constant in a
> "reachable scope". See e.g.,
> https://stackoverflow.com/a/43468519/176922 for a more detailed
> explanation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp e8ef21fd9c203ac5e10c17694393322151231435

> 
> 
> Diff: https://reviews.apache.org/r/67927/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on a number of platforms and compilers in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message