mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 67927: Removed unneeded lambda capture.
Date Mon, 16 Jul 2018 12:37:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67927/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Dario Rexin.


Repository: mesos


Description
-------

In some instances variables used in the body of a lambda do not need
to be captured explicitly. This patch removes the unneeded capture of
a constant integer initialized with a compile-time constant in a
"reachable scope". See e.g.,
https://stackoverflow.com/a/43468519/176922 for a more detailed
explanation.


Diffs
-----

  3rdparty/libprocess/src/tests/benchmarks.cpp e8ef21fd9c203ac5e10c17694393322151231435 


Diff: https://reviews.apache.org/r/67927/diff/1/


Testing
-------

Tested on a number of platforms and compilers in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message