mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 67876: Allowed resources to be removed in the hierarchical allocator.
Date Fri, 13 Jul 2018 19:01:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67876/#review206067
-----------------------------------------------------------


Fix it, then Ship it!




LGTM!


src/master/allocator/mesos/hierarchical.cpp
Line 925 (original), 938 (patched)
<https://reviews.apache.org/r/67876/#comment289018>

    indentation should be 4 here since we treat `CHECK_EQ` as a function


- Jie Yu


On July 10, 2018, 9:13 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67876/
> -----------------------------------------------------------
> 
> (Updated July 10, 2018, 9:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng Zhu.
> 
> 
> Bugs: MESOS-9015
>     https://issues.apache.org/jira/browse/MESOS-9015
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When applying `DESTROY_VOLUME` or `DESTROY_BLOCK` on a CSI volume with a
> stale profile, the volume will be converted to an empty resource to
> avoid it to be offered to frameworks. This patch updates the
> hierarchical allocator to allow such behaviors in `updateAllocation`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b

>   src/tests/hierarchical_allocator_tests.cpp 597469e0e897e10e9805798a4ec3f445c7dc28b0

> 
> 
> Diff: https://reviews.apache.org/r/67876/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message